Run PR CI on pull_request instead of pull_request_target - #8
Merged
Conversation
pullrequest.yml ran fork PRs under pull_request_target, which executes untrusted PR code with repo secrets available and a privileged GITHUB_TOKEN persisted by checkout. The PR jobs reference no secrets, so plain pull_request does the same work while GitHub withholds secrets and issues a read-only token for fork runs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pullrequest.yml ran fork PRs under
pull_request_target, which executes untrusted PR code with repo secrets available and a privilegedGITHUB_TOKENpersisted by checkout. The PR jobs here (test, license finder) reference no secrets, so plainpull_requestdoes the same work while GitHub withholds secrets and issues a read-only token for fork runs. Theevent_namechecks in the reusable workflows already handle this: onpull_requestthe default checkout picks the PR merge ref.Part of an org-wide sweep of
pull_request_targetuse (same change as viamrobotics/viam-python-sdk#1246).🤖 Generated with Claude Code